Removing python headers and Win32 Python2 inits in C++ #3011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
changed the title
datumbox
changed the title
fmassa
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Great, thanks!
For the future, we should try to figure out how to make the linker on Windows to not prune PyInit__C etc, as we are now (unnecessarily?) introducing a dependency on Python.h.
FYI we could probably move the #include <Python.h> inside the ifdef _WIN32 now.
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Removing python headers and code for Python2 compatibility. * Restoring python3 inits.
vfdev-5
pushed a commit
to Quansight/vision
that referenced
this pull request
Dec 4, 2020
* Removing python headers and code for Python2 compatibility. * Restoring python3 inits.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @fmassa, we do some clean up on the C++ files:
Unfortunately removing completely the initialization functions for Win32 is not possible.