Fixed audio-video synchronisation problem in read_video() when using pts as unit
#3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjuncek
approved these changes
May 11, 2021
bjuncek
reviewed
May 24, 2021
| config.video_fps, info['video_fps'], delta=0.0001 | ||
| ) | ||
| arr = torch.Tensor(arr) | ||
| if arr.shape == visual.shape: |
There was a problem hiding this comment.
Why is this necessary?
Wouldn't we expect them to be the same shape?
There was a problem hiding this comment.
There are some off by 1, which may be related to the differences in how the closest frame is found in pyav and torchvision(as we had discussed offline).
| arr.append(frame.to_ndarray()) | ||
| _, audio, _ = io.read_video(full_path, start_pts=start_pts_val, pts_unit='pts') | ||
| arr = torch.as_tensor(np.concatenate(arr, axis=1)) | ||
| if arr.shape == audio.shape: |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
…en using `pts` as unit (#3791) Summary: * Fixed audio-video synchronisation problem in read_video() when using as unit * Addressed review comments * Added unit test Reviewed By: NicolasHug Differential Revision: D29027305 fbshipit-source-id: 0a9dc3c877825af7836e7db313cfd2779542b457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.