Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Repeated Augment Sampler #5051

Merged
merged 5 commits into from
Dec 8, 2021
Merged

Conversation

yiwen-song
Copy link
Contributor

@yiwen-song yiwen-song commented Dec 7, 2021

This is a SUPER useful technique used in DeiT training, which helps bumping the ViT training accuracy for about 4-5%.
Therefore, we should also add it into pytorch vision reference script.

cc @datumbox

@facebook-github-bot
Copy link

facebook-github-bot commented Dec 7, 2021

💊 CI failures summary and remediations

As of commit 7e5fffc (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

As far as I can see, this is taken from DeIT's codebase. Since @fmassa is the author of that file and it's from a Meta repo, not sure if we need to put a reference. Francisco let me know if that's not the case.

@yiwen-song
Copy link
Contributor Author

I just left a comment inside the file saying this function is borrowed from DeiT repo, please let me know if there's some license issue I need to resolve furthermore @fmassa

@yiwen-song yiwen-song merged commit e250db3 into pytorch:main Dec 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Hey @sallysyw!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@yiwen-song yiwen-song deleted the ra_sampler branch December 8, 2021 01:21
facebook-github-bot pushed a commit that referenced this pull request Dec 9, 2021
Summary:
* Adding repaeted data-augument sampler

* rebase on top of latest main

* fix formatting

* rename file

* adding coode source

Reviewed By: NicolasHug

Differential Revision: D32950941

fbshipit-source-id: d30b50b9a7f8e65c676d7b89623c0bcf88792d40
@yiwen-song yiwen-song linked an issue Dec 10, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Vision Transformer to torchvision/models
3 participants