Add build-system requirements #6230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make project https://peps.python.org/pep-0517/ compliant Solves pytorch/pytorch#80745
datumbox
approved these changes
Jul 1, 2022
|
Hey @malfet! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
pmeier
reviewed
Jul 3, 2022
|
|
||
| [build-system] | ||
|
|
||
| requires = ["setuptools", "torch", "wheel"] |
There was a problem hiding this comment.
Adding torch as a requirement here does only somewhat solve this:
pipwill create a separate virtual env for these requirements, which means it will pulltorchfrom PyPI. That means you will get a CPU version for macOS and Windows and an outdated CUDA version (10.2 IIRC) for Linux.- We only have the stable binaries up on PyPI, but in general we depend on the current nightly.
Thus, even with this set, users could have problems building from source.
I don't have a solution for this. Just raising awareness.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
Summary: To make project https://peps.python.org/pep-0517/ compliant Solves pytorch/pytorch#80745 Reviewed By: jdsgomes Differential Revision: D37643905 fbshipit-source-id: 6f20b9c38a18ed9c0c189ef377a39b88716998fe
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make project PEP-517 compliant
Solves pytorch/pytorch#80745