Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S3D weights #6537

Merged
merged 3 commits into from
Sep 5, 2022
Merged

Update S3D weights #6537

merged 3 commits into from
Sep 5, 2022

Conversation

datumbox
Copy link
Contributor

@datumbox datumbox commented Sep 5, 2022

Continuation from work at #6412

Trained from scratch using the following recipe:

PYTHONPATH=$PYTHONPATH:`pwd` python -u run_with_submitit.py --ngpus 8 --nodes 8 --cache-dataset --batch-size=12 --lr 0.2 --clip-len 64 --clips-per-video 5 --sync-bn --model s3d --train-resize-size 256 256 --train-crop-size 224 224 --val-resize-size 256 256 --val-crop-size 224 224 --data-path="/datasets01_ontap_isolated/kinetics/070618/400/"
Submitted job_id: 59255

Validated with:

torchrun --nproc_per_node=8 train.py --data-path="/datasets01_ontap/kinetics/070618/400/" --batch-size=16 --test-only --cache-dataset --clip-len 128 --clips-per-video 1 --model s3d --weights S3D_Weights.KINETICS400_V1
 * Clip Acc@1 68.368 Clip Acc@5 88.050

Copy link
Contributor

@YosuaMichael YosuaMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @datumbox ! Overall looks good to me, just a single minor NIT.

references/video_classification/README.md Show resolved Hide resolved
@datumbox
Copy link
Contributor Author

datumbox commented Sep 5, 2022

The failing test is unrelated. It's a memory issue on Windows that started popping up recently. If it doesn't go away on itsown we may have to disable the mvit* GPU tests on windows.

@datumbox datumbox merged commit 9b432d0 into pytorch:main Sep 5, 2022
@datumbox datumbox deleted the models/s3d_new_weights branch September 5, 2022 13:18
facebook-github-bot pushed a commit that referenced this pull request Sep 9, 2022
Summary:
* S3D weight deployment

* Update accuracies.

* Address review comments.

Reviewed By: YosuaMichael

Differential Revision: D39381954

fbshipit-source-id: f62e69e8fc7aee2e4fa1334e2319f3a14645f159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants