Avoid recomputing the affine matrix in bbox rotate #6712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
commented
Oct 6, 2022
datumbox
commented
Oct 6, 2022
vfdev-5
reviewed
Oct 6, 2022
vfdev-5
reviewed
Oct 6, 2022
datumbox
changed the title
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
Summary: * Avoid recommuting the affine matrix in bbox rotate * Fix linter * inverted=True for estimating image size * Update the image size estimation to match the one from the image kernel * Nits * Address comments. * Center=0,0 when expand=true Reviewed By: NicolasHug Differential Revision: D40427463 fbshipit-source-id: 87e147e8a52c18d90601c6de4b1b182c60b9d8e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the TODO we had for eliminating the re-estimation of the rotation matrix.