-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proto] Performance improvements for equalize op #6757
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @vfdev-5 and @lezcano for making this fast! It's interesting that we can achieve this kind of performance optimization on the frontend without calling the native histogram methods. There might be some speed improvements to be achieved on the future on Core.
I see that all the tests pass, so this looks good to go.
@datumbox speaking with Mario, we can improve the code a bit more, I'll send an update in a follow-up PR. |
For reference, note that the speed-ups do not come from the histogram method itself. I just used that way of implementing a histogram because it allows to have batches. The main speed-up comes from using batched operations all across vs having a for loop and running all these kernels once per channel. |
Probably generalising |
Summary: * [proto] Performance improvements for equalize op * Added tests Reviewed By: NicolasHug Differential Revision: D40427459 fbshipit-source-id: 8cfba7a345b87fb56b7edcf58b7f9c7d526be813
Description:
cc @datumbox @NicolasHug