fix reference tests for convert_format_bounding_box #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Oct 28, 2022
|
|
||
|
|
||
| def reference_inputs_convert_format_bounding_box(): | ||
| for args_kwargs in sample_inputs_convert_color_space_image_tensor(): | ||
| for args_kwargs in sample_inputs_convert_format_bounding_box(): |
There was a problem hiding this comment.
This is the root cause. We are iterating over images and below checking for only two dimensions. Since no such images exist in the sample function, we never yielded and therefore never saw an error.
| @@ -536,12 +536,12 @@ def sample_inputs_convert_format_bounding_box(): | |||
|
|
|||
| def reference_convert_format_bounding_box(bounding_box, old_format, new_format): | |||
| return torchvision.ops.box_convert( | |||
| bounding_box, in_fmt=old_format.kernel_name.lower(), out_fmt=new_format.kernel_name.lower() | |||
| ) | |||
| bounding_box, in_fmt=old_format.name.lower(), out_fmt=new_format.name.lower() | |||
There was a problem hiding this comment.
These crept in during some auto-renaming, but were never caught since the test hasn't been run in the first place.
| bounding_box, in_fmt=old_format.kernel_name.lower(), out_fmt=new_format.kernel_name.lower() | ||
| ) | ||
| bounding_box, in_fmt=old_format.name.lower(), out_fmt=new_format.name.lower() | ||
| ).to(bounding_box.dtype) |
There was a problem hiding this comment.
We need this because the reference does not convert back to the original dtype. Thus, if we put in integer boxes, we might get floating point boxes out, which might have a value of .5.
pmeier
commented
Oct 28, 2022
Comment on lines
+41
to
+44
| if not args_kwargs: | ||
| raise pytest.UsageError( | ||
| f"Couldn't collect a single `ArgsKwargs` for `{info.id}`{f' in {test_id}' if test_id else ''}" | ||
| ) |
There was a problem hiding this comment.
This makes sure this doesn't happen again in the future.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 31, 2022
Summary: * fix reference tests for convert_format_bounding_box * add check to prevent empty args_kwargs_fns in the future Reviewed By: datumbox Differential Revision: D40851025 fbshipit-source-id: 5b95c2e3c2bf858edd79916b74fc529ec8ed7424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the reference tests for
convert_format_bounding_boxwere not run at all.cc @vfdev-5 @datumbox @bjuncek