[Nova] Disable Linux Wheels Builds from CircleCI #6954
Conversation
One strong reason for using CircleCI to build the docs, is that it allows us to host the generated HTML in the process. For example, you can find the docs built by this PR here: https://output.circle-artifacts.com/output/job/5083e59e-509d-4137-9f78-6a175f3e1d63/artifacts/0/docs/index.html. This makes it really easy to asses the impact of a PR on our documentation. Is something like this available for GHA? I know you can upload the artifacts, but I've never seen it being able to host the HTML. If not, can we maybe keep the docs workflow on CircleCI? |
|
@pmeier Sure, we can keep the docs builds on CircleCI until we have a good alternative. Exploring docs migration was anyways planned for sometime next year. |
There was a problem hiding this comment.
One comment below, otherwise no concerns from my side. Thanks Omkar!
For all other reviewers that might wonder why there is no change to .circleci/config.yml.in: the only change is inside the generation logic and thus we build a different .circleci/config.yml from the same template. Workflow that checks consistency of the two files is green: https://app.circleci.com/pipelines/github/pytorch/vision/21978/workflows/7e9d4ce5-9033-493a-92ff-9d273e48f7c5/jobs/1779312
| @@ -40,7 +40,7 @@ jobs: | |||
| smoke-test-script: ${{ matrix.smoke-test-script }} | |||
| # Using "development" as trigger event so these binaries are not uploaded | |||
| # to official channels yet | |||
| trigger-event: development | |||
There was a problem hiding this comment.
I'm guessing this is the change that actually uploads the wheels from GHA rather than from CircleCI, right? In any case, could you please remove the comment above this line, since it is no longer valid?
osalpekar
force-pushed
the
linux_wheels_migrate
branch
from
e1e3d60
to
abf8e98
Compare
osalpekar
force-pushed
the
linux_wheels_migrate
branch
from
abf8e98
to
513e815
Compare
|
Hey @osalpekar! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: * [Nova] Disable Linux Wheels Builds from CircleCI * remove old comment Reviewed By: YosuaMichael Differential Revision: D41518192 fbshipit-source-id: 07d69aad67f530a634929d9f85bb569f3b6ebe06
Nova binary build workflows have been running smoothly on trunk for a few weeks, so we are proceeding with the switch to Nova by disabling the corresponding builds from CircleCI. This PR starts this process by disabling Linux Wheels builds from CircleCI. We'll keep around the py.37 Linux Wheels jobs since docs builds depend on this, but that job will not upload any binaries. For all the other python/cuda versions, the Linux Wheels jobs will be disabled. We hope to migrate docs builds in the future as well, at which point the py3.7 linux wheels build will also be disabled.
cc @seemethere