raise kernel launch errors instead of just print #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @ppwwyyxx! Before merging, perhaps we should wait for pytorch/pytorch#91758 to be addressed? |
|
Sure! up to you. The pytorch bug is already in the last release so I feel waiting for the fix does not help much. |
|
ping @NicolasHug . The upstream bug was fixed |
NicolasHug
approved these changes
Jan 31, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
…ge in cuda ops (#7080) Summary: Co-authored-by: Yuxin Wu <ppwwyyxx@users.noreply.github.com> Reviewed By: vmoens Differential Revision: D43116114 fbshipit-source-id: 6fa3ace8de01255adb1a840cba2af902309d6137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the kernel fails to launch, an error should be raised.