Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove GTSRB from detection dataset list #7164

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 1, 2023

GTSRB is currently listed as classification

as well as detection dataset:

Although GTSRB can provide bounding boxes (and we use them in the v2 dataset)

bounding_box = BoundingBox(
[int(csv_info[k]) for k in ("Roi.X1", "Roi.Y1", "Roi.X2", "Roi.Y2")],
format="xyxy",
spatial_size=(int(csv_info["Height"]), int(csv_info["Width"])),
)

the v1 dataset only returns the label

samples = make_dataset(str(self._target_folder), extensions=(".ppm",))

Thus, this PR removes GTSRB from the detection dataset list.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip

@pmeier pmeier merged commit 97ce773 into pytorch:main Feb 2, 2023
@pmeier pmeier deleted the gtsrb-classification branch February 2, 2023 09:44
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@pmeier pmeier added the bug label Feb 2, 2023
facebook-github-bot pushed a commit that referenced this pull request Feb 9, 2023
Reviewed By: vmoens

Differential Revision: D43116111

fbshipit-source-id: 537a6cec0aaf09a05a556a5defdb5861e2bbef55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants