Make RandomApply torchscriptable in V2 #7256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
commented
Feb 15, 2023
NicolasHug
commented
Feb 15, 2023
Comment on lines
+45
to
+46
| def _extract_params_for_v1_transform(self) -> Dict[str, Any]: | ||
| return {"transforms": self.transforms, "p": self.p} |
There was a problem hiding this comment.
I don't understand why, but the transforms key was missing when using _extract_params_for_v1_transform() from the base class.
There was a problem hiding this comment.
nn.Module overwrites __setattr__. One of the things it is doing is to not assign other nn.Module's into self.__dict__, but rather into self._modules. Since we only go through self.__dict__, we don't pick up self.transforms since isinstance(nn.ModuleList(...), nn.Module).
There was a problem hiding this comment.
wow, good catch! thanks for the explanation
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
Reviewed By: vmoens Differential Revision: D44416608 fbshipit-source-id: 1e8afbc880dacacacbd2f3e543d21cb4b90e5fdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed it before
cc @vfdev-5 @bjuncek @pmeier