Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues in elastic transform #7257

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fixed issues in elastic transform #7257

merged 2 commits into from
Feb 15, 2023

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Feb 15, 2023 •
edited by pytorch-bot bot
Loading

Fixed TODO items for:

  • test_elastic_transform_asserts
  • test_elastic_transform_consistency

from https://github.com/pytorch/vision/pull/7159/files#diff-20aa863691d99392413c9057fec11225676f836367a22763b5cf25e68d4a6969R1326

cc @bjuncek @pmeier

NicolasHug
NicolasHug approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @vfdev-5 , can confirm the corresponding tests passed on #7159

@NicolasHug NicolasHug merged commit d805aea into pytorch:main Feb 15, 2023
@vfdev-5 vfdev-5 deleted the fix-elastic-tests branch February 15, 2023 14:43
@github-actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug mentioned this pull request Feb 15, 2023
Closed
49 tasks
facebook-github-bot pushed a commit that referenced this pull request Mar 28, 2023
@NicolasHug @facebook-github-bot
[fbsync] Fixed issues in elastic transform (#7257)
9cf580d 
Summary: Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>

Reviewed By: vmoens

Differential Revision: D44416566

fbshipit-source-id: 1f3b48b5d15d2004ced3d22844bd92fed9cb6d26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vfdev-5 @NicolasHug @facebook-github-bot