move parameter sampling of RandomPhotometricDistort into _get_params #7442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7442
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pmeier
commented
Mar 22, 2023
| @@ -228,19 +228,22 @@ def __init__( | |||
|
|
|||
| def _get_params(self, flat_inputs: List[Any]) -> Dict[str, Any]: | |||
| num_channels, *_ = query_chw(flat_inputs) | |||
| return dict( | |||
| zip( | |||
| ["brightness", "contrast1", "saturation", "hue", "contrast2"], | |||
There was a problem hiding this comment.
I'm not sure why we went for "contrast1" and "contrast2" before. Since we have the additional "contrast_before" flag, it is guaranteed, that they will never be applied at the same time. Meaning, there is no point in sampling them twice.
NicolasHug
approved these changes
Mar 22, 2023
NicolasHug
pushed a commit
to NicolasHug/vision
that referenced
this pull request
Mar 22, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
…t_params (#7442) Reviewed By: vmoens Differential Revision: D44416572 fbshipit-source-id: da21a5f8f85fa7959dc533f49f30db4f36a83515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This violated our requirement that parameters will only be sampled once. Meaning, without this PR, you will get multiple different distortions when passing multiple images.
cc @vfdev-5