Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make disable_tf32 context manager handle exceptions #7651

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 2, 2023

I.e. the pattern should always be:

  intro()
  try:
    yield:
  finally:
     outro()

I.e. follow the pattern outlined in I.e. follow pattern outlined in https://docs.python.org/3.8/library/contextlib.html#contextlib.contextmanager

I.e. the pattern should always be:
```
  intro()
  try:
    yield:
  finally:
     outro()
```

I.e. follow the pattern outlined in  I.e. follow pattern outlined in https://docs.python.org/3.8/library/contextlib.html#contextlib.contextmanager
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 2, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7651

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit b9ba2f7:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pmeier pmeier merged commit a5035df into main Jun 2, 2023
@pmeier pmeier deleted the malfet-patch-2 branch June 2, 2023 15:59
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jun 14, 2023
Reviewed By: vmoens

Differential Revision: D46724123

fbshipit-source-id: 69668fc75b962c4f0f2a13181340639cb421d75d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants