Fix the confusing example of gt_pred_pairs_of_highest_quality
#7730
Conversation
Correct the example of `gt_pred_pairs_of_highest_quality`. `torch.where(condition)` is identical to `torch.nonzero(condition, as_tuple=True)`. So the `gt_pred_pairs_of_highest_quality` is a tuple of LongTensor.
|
Hi @fansuregrin! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
fansuregrin
changed the title
gt_pred_pairs_of_highest_quality
There was a problem hiding this comment.
Thanks for the PR @fansuregrin . The changes look good but I suspect there will be formatting issues (see suggestion below). Thanks!
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Thank you @fansuregrin , merged! |
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
…ty` (#7730) Reviewed By: matteobettini Differential Revision: D48642244 fbshipit-source-id: 9a08924684da466b44c5043e7dec2cdff9e7dc4d Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>
Correct the example of
gt_pred_pairs_of_highest_quality.torch.where(condition)is identical totorch.nonzero(condition, as_tuple=True). So thegt_pred_pairs_of_highest_qualityis a tuple of LongTensor.