Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weight download URLs #7898

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Aug 29, 2023

Fixes #7744

TL;DR: some hash were wrong. After #7219 got merged, we started getting (expected) errors on those links.

This PR fixes the hashes/links. I re-uploaded the proper weights with the proper hashes on S3.

Script used to check all weights can be downloaded properly:

import torchvision.models


problems = []
for name in torchvision.models.list_models():
    print(name)
    kwargs = {"quantize": True} if "quantized" in name else dict()
    for weights in torchvision.models.get_model_weights(name):
        print(weights)
        try:
            torchvision.models.get_model(name, weights=weights, **kwargs)
        except RuntimeError as e:
            problems.append((name, weights, e))
            print(e)

print("Following models need to be fixed:")
for name, weights, e in problems:
    print(name, weights, e)

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 29, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7898

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit 4e9c0ea with merge base 655ebdb (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped, thanks @NicolasHug !

@NicolasHug NicolasHug merged commit ec881a0 into pytorch:main Aug 29, 2023
58 of 63 checks passed
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: matteobettini

Differential Revision: D48900385

fbshipit-source-id: 6d09e4d388b28eb927ffdb8d4a96e8e6bfadea88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretrained efficientnet_b0_rwrightman-3dd342df state_dict fails sha256 check
3 participants