Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashes of efficientnet weights #8036

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Oct 10, 2023

Fixes #8034

I doubled checked that all models are OK now:

import torchvision.models


problems = []
for name in torchvision.models.list_models():
    print(name)
    kwargs = {"quantize": True} if "quantized" in name else dict()
    for weights in torchvision.models.get_model_weights(name):
        print(weights)
        try:
            torchvision.models.get_model(name, weights=weights, **kwargs)
        except RuntimeError as e:
            problems.append((name, weights, e))
            print(e)

print("Following models need to be fixed:")
for name, weights, e in problems:
    print(name, weights, e)

Gives nothing:

...
Following models need to be fixed:

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 10, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8036

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 9 Unrelated Failures

As of commit 3a9f1d0 with merge base 0f74907 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just to check, we are ok breaking the old links here although the hash is wrong, correct?

@NicolasHug
Copy link
Member Author

We're not really breaking the links as I didn't remove the previous weights from the S3 bucket. I.e. the previous URLs still exist and one can download wieghts from them, should they want to. But those old URLs don't pass our hash-checking logic we introduced in 0.16 because the file names contained wrong hashes.

@NicolasHug NicolasHug merged commit 7e2050f into pytorch:main Oct 11, 2023
21 of 43 checks passed
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Oct 11, 2023
facebook-github-bot pushed a commit that referenced this pull request Nov 3, 2023
Reviewed By: vmoens

Differential Revision: D50789104

fbshipit-source-id: 96527d798892c278256fa6f7842a9331e83b1f64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to update Efficientnet weight
3 participants