S390x big endian fixes #8149
S390x big endian fixes #8149
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8149
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit c5a6393 with merge base 526ec93 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
AlekseiNikiforovIBM
force-pushed
the
s390x_transform
branch
from
9cfaacb
to
bb3edbc
Compare
|
CLA approval is in progress! |
AlekseiNikiforovIBM
force-pushed
the
s390x_transform
branch
2 times, most recently
from
f562877
to
b5130e2
Compare
I, L and F specifiers are actually endian-aware aliases. I;16 is a little-endian type. For big-endian I;16B has to be used. This change fixes multiple tests in test/test_transforms.py on s390x, including test_2d_ndarray_to_pil_image.
This change fixes multiple tests like MNISTTestCase::test_feature_types in test/test_datasets.py
AlekseiNikiforovIBM
force-pushed
the
s390x_transform
branch
from
b5130e2
to
c5a6393
Compare
There was a problem hiding this comment.
Please note, that currently there are no way to way to test those changes, but as long as it does not regress little-endian path, does not modify too many call-sites (if it becomes the case a better design+some sort of linter will be needed) and does not affect performance critical pass for LE systems
|
Hey @malfet! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
Summary: Fixes for multiple tests on s390x Reviewed By: vmoens Differential Revision: D52539006 fbshipit-source-id: 336bfea99390360329170300a7a3d9872fbbb807
Fixes for multiple tests on s390x