Fix CutMix and MixUp arguments in transforms.py #8287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both torchvision.transforms.v2.CutMix and torchvision.transforms.v2.MixUp uses num_classes instead of num_categories as arguments.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8287
Note: Links to docs will display an error until the docs builds have been completed. ❌ 33 New Failures, 7 Unrelated FailuresAs of commit 45cd8b1 with merge base 2c127da ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
reviewed
Mar 4, 2024
| @@ -13,13 +13,13 @@ def get_mixup_cutmix(*, mixup_alpha, cutmix_alpha, num_categories, use_v2): | |||
| mixup_cutmix = [] | |||
| if mixup_alpha > 0: | |||
| mixup_cutmix.append( | |||
| transforms_module.MixUp(alpha=mixup_alpha, num_categories=num_categories) | |||
| transforms_module.MixUp(alpha=mixup_alpha, num_classes=num_categories) | |||
There was a problem hiding this comment.
Thanks a lot for the report and for the fix @zhulinchng . Can you also change the signature of get_mixup_cutmix to accept a num_classes parameter instead of num_categories? This way, there would only be the num_classes parameter, and not num_categories.
There was a problem hiding this comment.
Thanks @NicolasHug for the suggestion, I have updated the PR with the changes to get_mixup_cutmix.
this replaces num_categories, for consistency
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
Reviewed By: vmoens Differential Revision: D55062763 fbshipit-source-id: 2cbc9ea8f78350a6c844c3ffd2b32c63b66e2c5c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both torchvision.transforms.v2.CutMix and torchvision.transforms.v2.MixUp uses num_classes instead of num_categories as arguments.