-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add float support to utils.draw_bounding_boxes()
#8328
add float support to utils.draw_bounding_boxes()
#8328
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8328
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 62346d6 with merge base 0367c21 (): NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @GeeCastro! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Just saw the activity on this PR. It might need a couple of tweaks because the input tensor is turned into a PIL Image etc... There's some rescaling happening as well. I'll get to it as soon as I get a chance 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @GeeCastro !
The changes look good, there were some test failure so I took the liberty to push some fixes (with a slightly different implementation) in 62346d6.
I'll merge once the CI is green, thank you!
Closes #8138 |
Reviewed By: vmoens Differential Revision: D57099464 fbshipit-source-id: efaaee482d743be2d33d5abfe350cb3efa1bd3e6 Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Follow-up PR: #8276 #8150
Issue: #8138
Add float support for
utils.draw_bounding_boxes()
following the same work done forutils.draw_segmentation_masks()
andutils.draw_keypoints()
Just came across this type issue (and mismatch with the
utils.save_image()
function.Credit to @GsnMithra and @NicolasHug
Closes #8138