[OpenXLA-pin-update trigger] Create _openxla_pin_update_weekly.yml #7108
Conversation
|
according to https://github.com/orgs/community/discussions/25746, we might be able to test this automatic OpenXLA-pin update trigger after we push this PR to master branch please correct me if I missed anything |
|
@will-cromar can you take a look? |
| title: "Weekly Code Update - ${{ env.CURRENT_DATE }}" | ||
| body: "This PR contains the weekly OpenXLA-pin update at commit: (HEAD commit: ${{ env.HEAD_COMMIT }}), with libtpu version at ${{ env.CURRENT_DATE }}." | ||
|
|
||
| - name: Add TPUCI label |
There was a problem hiding this comment.
create-pull-request has a labels option: https://github.com/marketplace/actions/create-pull-request#action-inputs
If the label is not on the PR when it is created, the TPU CI will not run.
There was a problem hiding this comment.
good suggestion, have we used create-pull-request before? wanna confirm before use
There was a problem hiding this comment.
thanks, added labels tpuci in current PR, please correct me if I understand wrong
There was a problem hiding this comment.
If the tpuci label is not on the PR when it is created, nothing will happen. I haven't use create-pull-request myself before, but I'm just going off of the documentation. Adding labels: tpuci to the step above should work.
There was a problem hiding this comment.
Thanks, updated above with labels: tpuci
There was a problem hiding this comment.
You can remove this last step since the PR will be created with that label
|
|
||
| - name: Get JAX version for specified date | ||
| run: | | ||
| version_line=$(curl -s https://raw.githubusercontent.com/google/jax/main/jax/version.py | sed -n '24p') |
There was a problem hiding this comment.
Hahaha, I like this. I'm okay to merge this so we can see if the workflow works at all, but if the line number where _version is defined ever changes, this will break. Please leave a comment so we know where to look if the JAX version doesn't update.
There was a problem hiding this comment.
Thanks, good idea, updated with comments
| title: "Weekly Code Update - ${{ env.CURRENT_DATE }}" | ||
| body: "This PR contains the weekly OpenXLA-pin update at commit: (HEAD commit: ${{ env.HEAD_COMMIT }}), with libtpu version at ${{ env.CURRENT_DATE }}." | ||
|
|
||
| - name: Add TPUCI label |
There was a problem hiding this comment.
If the tpuci label is not on the PR when it is created, nothing will happen. I haven't use create-pull-request myself before, but I'm just going off of the documentation. Adding labels: tpuci to the step above should work.
|
|
||
| - name: Update OpenXLA commit in WORKSPACE | ||
| run: | | ||
| sed -i "s/xla_hash =.*/xla_hash = '${{ env.GITHUB_ENV }}'/" WORKSPACE |
There was a problem hiding this comment.
This looks like a typo. env.GITHUB_ENV should be env.HEAD_COMMIT, right? $GITHUB_ENV holds the name of the file where workflow env vars are stored.
There was a problem hiding this comment.
Thanks, nice catch, updated to env.HEAD_COMMIT
| title: "Weekly Code Update - ${{ env.CURRENT_DATE }}" | ||
| body: "This PR contains the weekly OpenXLA-pin update at commit: (HEAD commit: ${{ env.HEAD_COMMIT }}), with libtpu version at ${{ env.CURRENT_DATE }}." | ||
|
|
||
| - name: Add TPUCI label |
There was a problem hiding this comment.
You can remove this last step since the PR will be created with that label
Add Github Action to create workflow enable create OpenXLA-pin update PR weekly Monday 9:00AM automatically