Register custom call with CUDA plugin #7219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten23
reviewed
Jun 11, 2024
vanbasten23
reviewed
Jun 11, 2024
vanbasten23
reviewed
Jun 11, 2024
vanbasten23
reviewed
Jun 11, 2024
|
Mostly lgtm with minor comments |
vanbasten23
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To integrate Triton kernels with HLO graph, we need to go through a custom call. PJRT CUDA Plugin uses a different code path to register custom calls. This PR adds the support to register custom call handlers for CUDA plugin.
CI changes:
Triton only works with GPUs with compute_capability > 7 and it requires torch with CUDA support. So, I added these tests to the workflow _test_requiring_torch_cuda.yml with new runners and updated the build files to build torch and PJRT CUDA plugin with the right GPU architecture support.