Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force to string output #7239

Merged
merged 2 commits into from
Jun 11, 2024
Merged

force to string output #7239

merged 2 commits into from
Jun 11, 2024

Conversation

zpcore
Copy link
Collaborator

@zpcore zpcore commented Jun 11, 2024 •
edited
Loading

Out torchbench run fails (link) because bigquery is unable to parse bool format:

'errors': [{'reason': 'invalid', 'location': 'metadata_value', 'debugInfo': '', 'message': 'Conversion from bool to std::string is unsupported.'}]}

@zpcore zpcore marked this pull request as ready for review June 11, 2024 16:15
@zpcore zpcore requested a review from vanbasten23 June 11, 2024 16:24
vanbasten23
vanbasten23 reviewed Jun 11, 2024
View reviewed changes
benchmarks/result_analyzer.py
@@ -104,6 +104,7 @@ def get_calculated_metrics(self, d, dataline):
return d

# TODO: handle error message properly (database length restriction)
# Do not use bool. This will mess up with the bigquery parsing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great comment!

vanbasten23
vanbasten23 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@vanbasten23 vanbasten23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@zpcore zpcore merged commit 0255964 into master Jun 11, 2024
21 of 22 checks passed
@zpcore zpcore deleted the piz/fix_bm_type branch June 11, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanbasten23 vanbasten23 vanbasten23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zpcore @vanbasten23