Port typing annotations and improve error messages #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhoese
changed the title
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 97.73% 98.11% +0.37%
==========================================
Files 6 6
Lines 662 689 +27
==========================================
+ Hits 647 676 +29
+ Misses 15 13 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Merging without review so I can continue on with porting other dask PRs for features and fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the many changes to dask related to type annotations and improved error messages. It also adds mypy to the pre-commit config and moves most configuration (including most of setup.py) into pyproject.toml. There are other dask PRs related to config changes that will be migrated after this is merged.