Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cached images producing different results without caching #96

Merged
merged 20 commits into from
Apr 3, 2023

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 29, 2023

This is a work in progress. For now I've only fixed readthedocs rendering, but I hope to fix #95.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

@coveralls
Copy link

coveralls commented Mar 29, 2023

Coverage Status

Coverage: 95.5% (+0.8%) from 94.675% when pulling 8d3e5b0 on djhoese:bugfix-dull-cache into 4687a0e on pytroll:main.

@djhoese
Copy link
Member Author

djhoese commented Mar 29, 2023

Well I can't even get the docs to build. It seems like readthedocs is installing the package in a way that doesn't include the package data (tests/test_data). I'll have to debug more in the morning.

@djhoese
Copy link
Member Author

djhoese commented Mar 29, 2023

Hm so RTD now works but github actions aren't running at all. Great.

@djhoese djhoese mentioned this pull request Mar 29, 2023
@djhoese djhoese marked this pull request as ready for review March 30, 2023 18:13
@djhoese djhoese requested a review from mraspaud March 30, 2023 18:13
@djhoese djhoese self-assigned this Mar 30, 2023
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djhoese djhoese merged commit 8d83d2e into pytroll:main Apr 3, 2023
@djhoese djhoese deleted the bugfix-dull-cache branch April 3, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cached overlays are pale
3 participants