Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable decoding of tbm dataset name #131

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Enable decoding of tbm dataset name #131

merged 2 commits into from
Aug 28, 2024

Conversation

mraspaud
Copy link
Member

This PR fixes the reading of dataset including TBM headers (POD files) which have cp500-(EBCDIC)-encoded dataset name field.

This fixes #130

@mraspaud mraspaud added the bug label Aug 27, 2024
@mraspaud mraspaud self-assigned this Aug 27, 2024
@mraspaud mraspaud mentioned this pull request Aug 27, 2024
Closed
@mraspaud mraspaud requested a review from sfinkens August 27, 2024 11:18
sfinkens
sfinkens reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this special format 😍 Just one comment, otherwise looks good to me!

pygac/pod_reader.py Outdated Show resolved Hide resolved
@mraspaud mraspaud merged commit 60f1849 into pytroll:main Aug 28, 2024
6 checks passed
@mraspaud mraspaud deleted the fix-tbm-decoding branch August 28, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfinkens sfinkens sfinkens approved these changes

Assignees

@mraspaud mraspaud

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read LAC files from NOAA CLASS
2 participants
@mraspaud @sfinkens