Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix striding slicing in AreaDefinition #193

Merged
merged 1 commit into from
May 16, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented May 16, 2019

I noticed that slicing an AreaDefinition with [::4, ::4] I was getting unexpected sizes like a 6000x10000 area becoming a 1499x2499 area. This PR fixes this off-by-one issue.

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

@djhoese djhoese added the bug label May 16, 2019
@djhoese djhoese requested a review from mraspaud May 16, 2019 20:36
@djhoese djhoese self-assigned this May 16, 2019
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #193 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   86.71%   86.71%   +<.01%     
==========================================
  Files          37       37              
  Lines        6818     6821       +3     
==========================================
+ Hits         5912     5915       +3     
  Misses        906      906
Impacted Files Coverage Δ
pyresample/geometry.py 84.84% <100%> (+0.03%) ⬆️
pyresample/test/test_geometry.py 97.08% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ddced8...e77285d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 86.688% when pulling e77285d on djhoese:bugfix-strided-area-slice into 5ddced8 on pytroll:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 86.688% when pulling e77285d on djhoese:bugfix-strided-area-slice into 5ddced8 on pytroll:master.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit a6e256b into pytroll:master May 16, 2019
@djhoese djhoese deleted the bugfix-strided-area-slice branch May 16, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants