Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update pyproj min version to 3.0.0 #487

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

bzah
Copy link
Contributor

@bzah bzah commented Dec 8, 2022

This PR update the min version of pyproj to 3.0 as pyresample relies on it already.

The only test that I did was to manually install pyproj 3.0 and to make sure import pyresample does throw an error.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #487 (20d1b4a) into main (35782d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          74       74           
  Lines       12890    12890           
=======================================
  Hits        12159    12159           
  Misses        731      731           
Flag Coverage Δ
unittests 94.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@djhoese djhoese added bug dependencies Pull requests that update a dependency file labels Dec 8, 2022
@djhoese djhoese self-assigned this Dec 8, 2022
@djhoese
Copy link
Member

djhoese commented Dec 8, 2022

Test failed due to an HTTP hiccup when sending coverage information to coveralls. I've restarted them.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.851% when pulling 20d1b4a on bzah:fix/pyproj_min_version into 35782d0 on pytroll:main.

@djhoese
Copy link
Member

djhoese commented Dec 8, 2022

Thanks for the fix!

@djhoese djhoese merged commit ef47ffd into pytroll:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Import fails due to misconfigured setup.py
3 participants