Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include package data #586

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

avalentino
Copy link
Contributor

@avalentino avalentino commented Feb 17, 2024

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff
  • Fully documented

Package data in pyresample/static/** are not installed without the patch.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b05353) 94.01% compared to head (72e9757) 94.01%.
Report is 43 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          92       92           
  Lines       13836    13836           
=======================================
  Hits        13008    13008           
  Misses        828      828           
Flag Coverage Δ
unittests 94.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 93.676%. remained the same
when pulling 72e9757 on avalentino:bugfix/package-data
into 60b4b38 on pytroll:main.

@djhoese
Copy link
Member

djhoese commented Feb 28, 2024

@mraspaud could you review this, merge it, and make a patch release to include it so people can properly do a repr of an AreaDefinition in a jupyter notebook. CC @BENR0

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud added the bug label Feb 29, 2024
@mraspaud mraspaud merged commit d5e437f into pytroll:main Feb 29, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants