Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch on pytest-lazy-fixtures #613

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

shadchin
Copy link
Contributor

@shadchin shadchin commented Aug 16, 2024

pytest-lazy-fixture has problems with pytest 8+ TvoroG/pytest-lazy-fixture#65

pytest-lazy-fixture has problems with pytest 8+
@mraspaud
Copy link
Member

Thanks for the switch! that was on our todo list, but you beat us to it :)

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle this looks good to me. Let's see what the CI says. And also, do you think we can unpin pytest?

@@ -24,7 +24,7 @@ dependencies:
- coverage
- pytest <8.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can pytest be unpinned now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (9bf142c) to head (5f69bd8).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #613   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files          86       86           
  Lines       13811    13811           
=======================================
  Hits        12979    12979           
  Misses        832      832           
Flag Coverage Δ
unittests 93.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Aug 16, 2024

Coverage Status

coverage: 93.677%. remained the same
when pulling 5f69bd8 on shadchin:pytest_lazy_fixtures
into 7798e20 on pytroll:main.

@djhoese
Copy link
Member

djhoese commented Aug 22, 2024

Thanks! Merging...

@djhoese djhoese merged commit 6ba78d2 into pytroll:main Aug 22, 2024
26 checks passed
@djhoese djhoese added the bug label Aug 22, 2024
@shadchin shadchin deleted the pytest_lazy_fixtures branch August 25, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants