Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converter for Electro-L N2 MSU/GS spectral response functions #144

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Feb 4, 2022

This adds the spectral response functions for the Electro-L N2 satellite's MSU-GS sensor. Unfortunately it's only for the N2 sat as I can't find RSRs for the N1 or N3 sats, but will update the code in future if I can get them.

I also added a section to pyspectral.yaml but commented it out and updated the readme. In addition to adding Electro-L to the readme I also took the liberty of changing @adybbroe as author to "Pytroll developers" as I think quite a few people have worked on this. Hope that's OK!

  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented

@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #144 (9983f46) into main (247676b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   84.18%   84.18%           
=======================================
  Files          23       23           
  Lines        2454     2454           
=======================================
  Hits         2066     2066           
  Misses        388      388           
Flag Coverage Δ
unittests 84.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyspectral/utils.py 65.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247676b...9983f46. Read the comment docs.

@adybbroe adybbroe self-assigned this Feb 7, 2022
@adybbroe adybbroe self-requested a review February 7, 2022 15:26
Copy link
Collaborator

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Just fix the small cut'n'paste thingy

I tested it and this gives me a plot of the responses for the three short wave channels:
python bin/composite_rsr_plot.py -p Electro-L-N2 -s msu-gs --range 0.4 0.9

rsr_convert_scripts/msu_gs_reader.py Outdated Show resolved Hide resolved
@adybbroe
Copy link
Collaborator

adybbroe commented Feb 7, 2022

@simonrp84
I will soon add the hdf5 file to zenodo.org and then we can update the URL in utils.py. And then we can merge...

@adybbroe
Copy link
Collaborator

As I said in your other PR #145 I have updated the RSR on zenodo.org, so you can update the URL and version in utils.py now.

Adam.Dybbroe added 2 commits February 10, 2022 14:37
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Signed-off-by: Adam.Dybbroe <a000680@c21856.ad.smhi.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants