You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
We are looking into combining metadata in MultiFiller when producing a world composite (see #2446 for additional context). If we use combine_metadata as is, we would either get the start_time and end_time of the first dataset to be combined, or we would get the average. Neither are correct for producing a world composite. Rather, we would want the minimum of all start_times and the maximum of all end_times.
Describe the solution you'd like
We would like that combine_metadata gets more flexibility in how to handle differing times. The user should be able to pass a mapping of time variables to actions, where actions can be (for example) "first", "average", "minimum", "maximum", or maybe others.
Describe any changes to existing user workflow
The current API can be retained for backward compatibility.
Additional context
See #2446 for additional context. We could refrain from using combine_metadata or accept its limitations.
The text was updated successfully, but these errors were encountered:
I completely agree that the averaging of start/end time is probably never the right way of handling it. As mentioned in slack (I think?) the the MultiScene's stack blend function handles start/end with min/max and so does the metadata handling inside the base file handler when readers need to concatenate multiple granules or segments into a single DataArray. In this file handler case it also does this with start/end orbit metadata. I guess it is time this functionality moves into the combine_metadata function.
I personally don't think we should add the ability to choose first/average/min/max. I'm not sure that would ever be needed. I think we add special handling for start/end prefixed metadata and leave the rest as an average. Oh I suppose we'd need special handling for all time_parameters time metadata.
Feature Request
Is your feature request related to a problem? Please describe.
We are looking into combining metadata in
MultiFiller
when producing a world composite (see #2446 for additional context). If we usecombine_metadata
as is, we would either get thestart_time
andend_time
of the first dataset to be combined, or we would get the average. Neither are correct for producing a world composite. Rather, we would want the minimum of allstart_time
s and the maximum of allend_time
s.Describe the solution you'd like
We would like that
combine_metadata
gets more flexibility in how to handle differing times. The user should be able to pass a mapping of time variables to actions, where actions can be (for example) "first", "average", "minimum", "maximum", or maybe others.Describe any changes to existing user workflow
The current API can be retained for backward compatibility.
Additional context
See #2446 for additional context. We could refrain from using
combine_metadata
or accept its limitations.The text was updated successfully, but these errors were encountered: