Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

available_readers to detail unavailable items #333

Closed
mraspaud opened this issue Jun 24, 2018 · 3 comments
Closed

available_readers to detail unavailable items #333

mraspaud opened this issue Jun 24, 2018 · 3 comments
Labels
enhancement code enhancements, features, improvements good first issue help wanted

Comments

@mraspaud
Copy link
Member

Is your feature request related to a problem? Please describe.
As a debugging feature, it would be really helpful to have available_readers detail the reason why the unavailable reader aren't available.

Describe the solution you'd like
A possible solution would be to print out the error happening upon attempting to load the unavailable readers.

Describe any changes to existing user workflow
As this is a purely for debugging purposes, no changes in the workflow will happen.

Additional python or other dependencies
No additional dependencies

Describe any changes required to the build process
No changes to the build process

Describe alternatives you've considered
No alternatives.

Additional context
No context.

@mraspaud mraspaud added enhancement code enhancements, features, improvements help wanted good first issue labels Jun 24, 2018
@djhoese
Copy link
Member

djhoese commented Jun 24, 2018

Would this be a keyword argument? Would the errors be put in to debug/error log messages or in the returned value somehow? If log messages then I suppose it could always log the reasons?

@mraspaud
Copy link
Member Author

I could be a kw arg that would print a report on screen, while still returning the list as expected.

@djhoese
Copy link
Member

djhoese commented Dec 1, 2018

This has been fixed by @mraspaud by adding the check_satpy utility function.

@djhoese djhoese closed this as completed Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements good first issue help wanted
Projects
None yet
Development

No branches or pull requests

2 participants