-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility functions for generating GeoViews plots #541
Conversation
…erence and can not be converted to string
- Added wishlist to Scene arguments to be able to specify desired datasets prior to loading which is important when using multiscene - Added printing of available dataset ids when no datasets are loaded yet
I may need to open a separate issue for the dask display (if I haven't already). I did some hacky features like this in a notebook I have locally but it was extremely slow. It used an HTML table where each table cell was the exact size of the array chunk that it represented. I then made a custom class with a |
Well that really sounds hacky :-). I did a little research and maybe it is possible using holoviews.streams Pipes but I am not sure. I asked the folks at pyViz but have no answer yet. |
Yeah I talked to the ipywidgets folks about this about 6 months ago. They had different packages that I could try out (ipyleaflet, etc). I am also the maintainer of the vispy project which has a notebook widget for doing webgl displays but this may be too complicated. @mraspaud and I brought this up again on slack last week after ipywidgets (I think) announced a new streaming API for streaming video. I'm not sure what would need to go in to that to make image data (a numpy array) look like a stream. In the end it would be cool if we could have two types of displays:
|
Fix more files
from satpy.node import DependencyTree | ||
from satpy.readers import DatasetDict, load_readers | ||
from satpy.resample import (resample_dataset, | ||
prepare_resampler, get_area_def) | ||
from satpy.writers import load_writer | ||
from pyresample.geometry import AreaDefinition, BaseDefinition | ||
from pyresample.utils import proj4_str_to_dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F401 'pyresample.utils.proj4_str_to_dict' imported but unused
""" | ||
try: | ||
import geoviews as gv | ||
from cartopy import crs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F401 'cartopy.crs' imported but unused
@@ -261,3 +261,4 @@ def atmospheric_path_length_correction(data, cos_zen, limit=88.): | |||
corr = corr.where(cos_zen > limit).fillna(corr_lim) | |||
|
|||
return data * corr | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W391 blank line at end of file
@BENR0 How goes the git hell with this one? |
@djhoese unfortunately currently I am busy with preparations for a paper presentation so I don't find enough time to take care of the PRs. I already fixed the superfluous imports which stickler came up with this is due to the change from handling the crs manually vs using the to_cartopy_crs method. The wishlist issue is a left over from the git hell ;-) which is also fixed. Just hasen't been pushed yet. I guess there are still some "lose ends" which in the long run should be improved so this functionality fits in better (geoviews as well as the to_xarray_dataset method) but as you said as long as its only used with geoviews this should be fine for now. So the things which are left to take care of from my point of view are:
Apart from that maybe you have some more Ideas/ wishes for changes. In that case please let me know. |
Closing since #567 replaces it. |
Adds to_geoviews Scene method as show during the Pytroll Developer Week in Darmstadt.
Additionally a new blending function for the MultiScene is added to generate a "timeseries" Scene which in turn can also be used with the geoviews method.
Some documentation is also added. If the data "problem" can be solved Ican also add some Jupyter Notebook examples.
This too can be considered as a work in progress. It's not extensively tested and probably could be improved a lot but maybe is a nice addition to the show method when working in a Notebook.