-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vaisala GLD360-reader. #687
Conversation
Reader done with test data representing one full day, supported file type is |
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 82.65% 82.69% +0.04%
==========================================
Files 161 163 +2
Lines 23435 23491 +56
==========================================
+ Hits 19370 19426 +56
Misses 4065 4065
Continue to review full report at Codecov.
|
@sjoro What's the status on this ? I the PR feature-complete ? do you plan to add tests ? |
@mraspaud from my side it done for now. was thinking about possible test(s) for checking the sensitivity for the input format, but i'd like to get some brainstorming help with that. |
Ok, we can talk about it next week. |
Added a test for the file handler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! One general idea: What about adding time
, longitude
and latitude
as non-dimensional y
-coordinates to the power
dataset?
xarr = xr.DataArray(da.from_array(self.data['power'],
chunks=CHUNK_SIZE), dims=["y"])
xarr['time'] = ('y', self.data['time'])
xarr['longitude'] = ('y', self.data['longitude'])
xarr['latitude'] = ('y', self.data['latitude'])
You would have to set units and standard name manually though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some nitpicking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another nitpicker... 😄 Otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sjoro can you add this reader to the reader table in the index.rst file (in the doc) ? |
Add a draft-version reader for Vaisala GLD360 (Global Lightning Detection) data.
git diff origin/master -- "*py" | flake8 --diff