-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose bucket resampling from Pyresample #768
Conversation
Before merging pytroll/pyresample#192 needs to be merged first. |
And naturally the tests need to be re-run after merging the Pyresample PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this nice piece of work! Just two comments.
…atpy into feature-bucket-resampling
What was the reason for removing fraction resampling? |
After the suggestion by @djhoese I added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions and one small change. Otherwise, looks good.
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
+ Coverage 85.16% 85.27% +0.11%
==========================================
Files 174 174
Lines 25500 25741 +241
==========================================
+ Hits 21716 21951 +235
- Misses 3784 3790 +6
Continue to review full report at Codecov.
|
This PR exposes the different bucket resampling methods from Pyresample to Satpy.
git diff origin/master -- "*py" | flake8 --diff