Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose bucket resampling from Pyresample #768

Merged
merged 34 commits into from
Sep 19, 2019

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented May 16, 2019

This PR exposes the different bucket resampling methods from Pyresample to Satpy.

  • Tests added
  • Tests passed
  • Passes git diff origin/master -- "*py" | flake8 --diff
  • Fully documented

@pnuu pnuu self-assigned this May 16, 2019
satpy/resample.py Outdated Show resolved Hide resolved
satpy/resample.py Outdated Show resolved Hide resolved
satpy/resample.py Outdated Show resolved Hide resolved
satpy/resample.py Outdated Show resolved Hide resolved
@pnuu pnuu requested a review from sfinkens May 24, 2019 08:38
@pnuu
Copy link
Member Author

pnuu commented May 24, 2019

Before merging pytroll/pyresample#192 needs to be merged first.

@pnuu
Copy link
Member Author

pnuu commented May 24, 2019

And naturally the tests need to be re-run after merging the Pyresample PR.

Copy link
Member

@sfinkens sfinkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice piece of work! Just two comments.

satpy/resample.py Outdated Show resolved Hide resolved
satpy/resample.py Outdated Show resolved Hide resolved
@djhoese
Copy link
Member

djhoese commented May 24, 2019

What was the reason for removing fraction resampling?

satpy/tests/test_resample.py Outdated Show resolved Hide resolved
satpy/tests/test_resample.py Show resolved Hide resolved
@pnuu
Copy link
Member Author

pnuu commented May 28, 2019

After the suggestion by @djhoese I added the bucket_fraction resampler, which concatenates the resulting category fractions and adds a categories dimension.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions and one small change. Otherwise, looks good.

satpy/resample.py Show resolved Hide resolved
satpy/resample.py Show resolved Hide resolved
satpy/resample.py Show resolved Hide resolved
@mraspaud mraspaud added this to the v0.17.0 milestone Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #768 into master will increase coverage by 0.11%.
The diff coverage is 97.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
+ Coverage   85.16%   85.27%   +0.11%     
==========================================
  Files         174      174              
  Lines       25500    25741     +241     
==========================================
+ Hits        21716    21951     +235     
- Misses       3784     3790       +6
Impacted Files Coverage Δ
satpy/tests/test_resample.py 98.32% <100%> (+0.6%) ⬆️
satpy/resample.py 92.94% <93.9%> (+0.17%) ⬆️
satpy/readers/avhrr_l1b_gaclac.py 90.14% <0%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b47e0...b32428b. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.276% when pulling b32428b on pnuu:feature-bucket-resampling into d1b47e0 on pytroll:master.

@mraspaud mraspaud merged commit 78d9aa7 into pytroll:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:resampling PCW Pytroll Contributors' Week
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants