Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a reader for NOAA GOES-R ABI L2+ products (abi_l2_nc) #904

Merged
merged 52 commits into from
Sep 17, 2019

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 17, 2019

This is a replacement of #767. That PR was made with @yufeizhu600's master branch so I didn't have push permissions. This PR is the same as that one except I merged master in to it and did a few small docstring cleanups. I also removed the __init__ definition in the l2 reader module because it was unnecessary.

Yufei Zhu and others added 30 commits May 15, 2019 17:20
nc_abi_l2 reader for NOAA GOES-R L2+ products in netCDF format.
remove local tests to avoid stickler-ci SyntaxError complain.
add blank lines in test scripts to make stickler happy.
@djhoese djhoese self-assigned this Sep 17, 2019
@djhoese djhoese changed the title Zufeizhu600 master Add a reader for NOAA GOES-R ABI L2+ products (abi_l2_nc) Sep 17, 2019
@coveralls
Copy link

coveralls commented Sep 17, 2019

Coverage Status

Coverage increased (+0.2%) to 85.087% when pulling 9939a5c on djhoese:zufeizhu600-master into 1389229 on pytroll:master.

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #904 into master will increase coverage by 0.24%.
The diff coverage is 85.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   84.84%   85.09%   +0.24%     
==========================================
  Files         171      174       +3     
  Lines       25297    25428     +131     
==========================================
+ Hits        21464    21637     +173     
+ Misses       3833     3791      -42
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_scmi.py 96.19% <100%> (ø) ⬆️
satpy/tests/reader_tests/__init__.py 98.18% <100%> (+0.06%) ⬆️
satpy/readers/abi_l2_nc.py 27.27% <27.27%> (ø)
satpy/tests/reader_tests/test_abi_l1b.py 96.36% <83.33%> (-0.86%) ⬇️
satpy/readers/abi_l1b.py 98.3% <88.88%> (+3.68%) ⬆️
satpy/readers/abi_base.py 90.82% <90.82%> (ø)
satpy/tests/reader_tests/test_abi_l2_nc.py 94.02% <94.02%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1389229...9939a5c. Read the comment docs.

@djhoese djhoese merged commit d207e85 into pytroll:master Sep 17, 2019
@djhoese djhoese deleted the zufeizhu600-master branch September 17, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants