-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add colorize and palettize to XRImage enhancement_history #99
Conversation
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 92.21% 92.26% +0.05%
==========================================
Files 10 10
Lines 3389 3411 +22
==========================================
+ Hits 3125 3147 +22
Misses 264 264
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm 90% sure of the logic on this, but would appreciate a double check. I would like this functionality for my own scripts in my Polar2Grid and Geo2Grid projects. With this the geotiff scale and offset metadata values include the range of the colormap used in palettize or colorize. I can then use that to determine the min/max of the original data so a colorbar can be added (with pydecorate) with the correct limit labels.
git diff origin/master **/*py | flake8 --diff
(remove if you did not edit any Python files)