Add the fetcher functionality and documentation on rtd #198
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
+ Coverage 91.30% 91.72% +0.42%
==========================================
Files 26 28 +2
Lines 5437 5666 +229
==========================================
+ Hits 4964 5197 +233
+ Misses 473 469 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mraspaud
changed the title
There was a problem hiding this comment.
Looks really nice to me! Thanks. Only one tiny correction.
But would be good to have some more eyes on it. @TAlonglong or @pnuu ?
Co-authored-by: Adam Dybbroe <adybbroe@users.noreply.github.com>
| port: 1979 | ||
| subscriber_config: | ||
| addresses: | ||
| - ipc://some_pipe |
There was a problem hiding this comment.
Is this "inter-process communication" protocol? I didn't know Posttroll supported other than tcp://.
There was a problem hiding this comment.
Yeah, tcp is hardcoded here and there in posttroll, but when passing addresses directly anything zeromq supports should work
This PR adds a pytroll-fetcher script and functionality to download files received through messages, and documentations pages for trollmoves to be hosted on readthedocs.