Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in string formatting usage example and drop Python 2.7 tests #21

Merged
merged 4 commits into from
Feb 14, 2020
Merged

Fix typo in string formatting usage example and drop Python 2.7 tests #21

merged 4 commits into from
Feb 14, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 13, 2020

Closes #20

Was a : in the docs, should be a !.

@djhoese djhoese added the bug label Feb 13, 2020
@djhoese djhoese requested a review from pnuu February 13, 2020 17:21
@djhoese djhoese self-assigned this Feb 13, 2020
pnuu
pnuu approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick PR 😁

@coveralls
Copy link

coveralls commented Feb 13, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 94.908% when pulling 3267471 on djhoese:doc-conversion-typo into c37ad63 on pytroll:master.

@djhoese djhoese changed the title Fix typo in string formatting usage example Fix typo in string formatting usage example and drop Python 2.7 tests Feb 13, 2020
@djhoese
Copy link
Member Author

djhoese commented Feb 13, 2020

Note: There was a small code change in the parser.py code for escape sequences because Python 3.7 was complaining about it. Based on the tests my updated code seems to be fine.

mraspaud
mraspaud approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the switch to pytest !

@mraspaud mraspaud merged commit 137b909 into pytroll:master Feb 14, 2020
@djhoese djhoese deleted the doc-conversion-typo branch February 14, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud approved these changes

@pnuu pnuu Awaiting requested review from pnuu

Assignees

@djhoese djhoese

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special conversion specifiers do not work
4 participants
@djhoese @coveralls @mraspaud @pnuu