Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-vendorize toml. #39

Merged
merged 1 commit into from
Jan 10, 2020
Merged

De-vendorize toml. #39

merged 1 commit into from
Jan 10, 2020

Conversation

wadevries
Copy link
Contributor

@wadevries wadevries commented Nov 12, 2019 •
edited
Loading

The __spec__ assignment in vendor/toml.py breaks autoreload in Django
(when importing dparse (through safety)).

@wadevries
De-vendorize toml.
5a6337c 
The __spec__ assignment in vendor/toml.py breaks autoreload in Django
(when importing dparse (through safety)).
@pombredanne
Copy link
Contributor

Thanks! Can you re-target this PR to the dev branch instead?
Also I have no idea why things fail on the Travis side.. Would you know?

@pombredanne
Copy link
Contributor

Actually let me close this and reopen one alright!

@pombredanne pombredanne reopened this Jan 10, 2020
@pombredanne
Copy link
Contributor

Sorry for the confusion... we have no dev branch here!

@pombredanne pombredanne merged commit e51c053 into pyupio:master Jan 10, 2020
@pombredanne
Copy link
Contributor

Thanks again!

@wadevries wadevries deleted the devendorize-toml branch January 10, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wadevries @pombredanne