-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pyproject.toml #71
Migrate to pyproject.toml #71
Conversation
cfde668
to
3d4b9ca
Compare
@oz123 is it good for you now? |
I'm not going to be able to merge this PR.. Not an owner here. I'm just sharing my thoughts. |
@oz123 I want to do 1:1, removing the pipenv dependencies, even undue, would be more than the minimum. I will do if the project owner ask for it, though. If he ever shows up. |
@yeisonvargasf can I have a workflow run please? |
@yeisonvargasf it's ready to be merged if you're OK with that. Btw, I think we should follow @oz123 's recommandation: the optional requirements on an old version of Pipenv doesn't make sense (it can't be enforced that way). |
Hi @oz123, thank you for reviewing this PR; I appreciate your help here. @deronnax, thank you for this PR; I agree with the @oz123 recommendation about removing the Pipenv constraint; My idea is to remove it after updating the Please let me know if the comment about the CI case is wrong; if the constraint doesn't work in that case, we can remove it in this same PR; otherwise, I'm happy to merge this as it is. |
pyproject.toml is the way to go