Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kochanek Spline function #1603

Merged
merged 7 commits into from
Aug 22, 2021
Merged

Add Kochanek Spline function #1603

merged 7 commits into from
Aug 22, 2021

Conversation

tkoyama010
Copy link
Member

Overview

Add Kochanek Spline function

See #1600

resolves #1600

Details

kochanek_spline = pv.KochanekSpline(
    points,
    continuity=[-1.0, -1.0, -1.0],
    tension=[0.0, 0.0, 0.0],
    bias=[0.0, 0.0, 0.0],
    n_points=1000,
)

kochanek-spline

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #1603 (d079534) into main (ba6c84f) will increase coverage by 0.03%.
The diff coverage is 97.56%.

@@            Coverage Diff             @@
##             main    #1603      +/-   ##
==========================================
+ Coverage   90.04%   90.07%   +0.03%     
==========================================
  Files          69       69              
  Lines       13154    13195      +41     
==========================================
+ Hits        11845    11886      +41     
  Misses       1309     1309              

@tkoyama010 tkoyama010 marked this pull request as ready for review August 21, 2021 05:58
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor changes. LGTM!

@tkoyama010 tkoyama010 merged commit 86bb557 into main Aug 22, 2021
@tkoyama010 tkoyama010 deleted the feat/KochanekSpline branch August 22, 2021 00:06
@akaszynski akaszynski mentioned this pull request Sep 10, 2021
@tkoyama010 tkoyama010 added the enhancement Changes that enhance the library label Oct 8, 2021
@akaszynski akaszynski mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Kochanek–Bartels spline
2 participants