Fix find_closest_cell examples doctest
#1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooops messed up my branch, I will need to rebase and force push I think. |
MatthewFlamm
force-pushed
the
fix-cell-center-example-doctest
branch
from
3a6d551
to
34b2347
Compare
MatthewFlamm
force-pushed
the
fix-cell-center-example-doctest
branch
from
34b2347
to
f23d205
Compare
Codecov Report
@@ Coverage Diff @@
## main #1809 +/- ##
=======================================
Coverage 92.61% 92.61%
=======================================
Files 71 71
Lines 14029 14029
=======================================
Hits 12993 12993
Misses 1036 1036 |
adeak
reviewed
Nov 17, 2021
adeak
approved these changes
Nov 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #1800. This PR fixes the doctest here by removing the block of code that relies on random points to converge to some value. It instead reworks the first block to verify that the cell chosen is indeed the closest cell to the chosen point.
The supplied point was changed as the point
[0, 0, 0.5]is equidistant to many cells to within 8-9 digits of precision. See #1800 (comment)