-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotate teapot for flip_z() doctest example #2885
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2885 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 76 76
Lines 16428 16428
=======================================
Hits 15449 15449
Misses 979 979 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I thought the labeler was fixed...
Actually, seems like this fails for forks... @tkoyama010, let's find a way to disable this for forks. |
At worst I can start using feature branches on the main repo. Vast majority of PRs seems to come from members anyway. |
I wouldn't want to discourage forks. Let's get it working for forks. |
@akaszynski Could you please check that the setting is the follwing? |
@banesullivan, are we fine with upping the scope on |
I reverted the trigger of labeling which is dropping in #2877. |
I'm comfortable with this, just so long as we aren't using a Personal Access Token (PAT) which can have elevated permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM.
It indeed is set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The
flip_z()
doctest result looks like this:The teapots look identical because the xy plane in this configuration is parallel to the symmetry plane of the teapot.
If we first rotate the teapot around
x
we get a more meaningful result:This makes the test slightly different from
flip_x()
andflip_y()
, but it's probably more important to have the example be useful in isolation.