Additonal revert of #2877

[tkoyama010]

Overview

Additonal revert of #2877

Details

• Relate to Rotate teapot for flip_z() doctest example #2885

[codecov]

Codecov Report

Merging #2886 (6ff5b37) into main (8ba5eca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2886   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          76       76           
  Lines       16428    16428           
=======================================
  Hits        15449    15449           
  Misses        979      979           

[akaszynski]

Still LGTM.

[akaszynski]

@tkoyama010, since I've check and we indeed have the right permissions in Workflow permissions
, should we make sure this doesn't run on forks?

[tkoyama010]

@akaszynski No. Thanks and sorry for this trouble. I will try a dummy account to see if it works.

[adeak]

@akaszynski No. Thanks and sorry for this trouble. I will try a dummy account to see if it works.

If my PRs are any indication, it's enough to open a PR from a branch on tkoyama010/pyvista instead of pyvista/pyvista.

[tkoyama010]

@adeak Thanks. I forked it now https://github.com/tkoyama010/pyvista . Could you please open test Pull Request with "document" label? This is after merged this Pull Request.

[adeak]

Sure, I can do that, just ping me once this is merged (I'll probably forget otherwise).

But we should make sure we all mean the same thing. I took @akaszynski's comment about "running on forks" to refer to cases like #2885: someone opening a PR to pyvista/pyvista from a branch at user/pyvista. So what I meant was for you to do that: opening a proper pyvista PR, but instead of using a (test) feature branch on the pyvista/pyvista repo, use a branch on your fork (like I did with my fork at adeak/pyvista).

From what you said it seems you suggested that I open a PR to your fork from my fork. And now I'm not sure what @akaszynski meant exactly 😄 I can help with any configuration, assuming we three agree on a test setup.

[tkoyama010]

@adeak Now I made a forked repository.

[adeak]

@tkoyama010 I think @akaszynski tested this already in #2889.