Skip to content

Also ask pip not to install build dependencies during editable install when using conda #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

ceball
Copy link
Contributor

@ceball ceball commented Jan 22, 2020

If you pip install -e . when using conda, any missing dependencies are installed by pip. You can avoid that by passing --no-deps to the pip command. (pyctdev ecosystem=conda installs all deps using conda, so --no-deps just avoids pip checking all the deps and finding them all present.)

With pip now supporting build dependencies, we should also ask pip not to install the build dependencies when we're using conda. Otherwise, pip will spend time creating an isolated environment and installing all the build dependencies before running setup.py, which is at best a waste of time (as the dependencies are already available, from conda). (At worst, there could be some subtle problem or conflict, although I haven't encountered that in practice yet.)

I don't know when the 'no build isolation' option appeared - not sure if I missed it originally, or if it wasn't present in the pip of that era (also not sure if pip was installing build deps back then).

@ceball ceball merged commit 5521b07 into master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant