Deprecate DFrame conversion methods #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge as soon as tests pass, I am assuming these are untested but may be wrong. |
|
PR build failure was the a transient failure, ready to merge whenever. Also yay, first time we broke the 77% coverage mark I believe. |
|
Looks good. I brought back the changelog wiki page so we don't forget to mention this on release. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm not ready to drop these interfaces entirely (I use some of the types like
DistributionandRegressionfrequently), the conversion methods on the pandas/seaborn interface types have long been marked with a deprecation warning so I think we can safely remove them for v1.7.