Fix Dynamic utility operation parameter updates #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the right thing to do, to me. |
philippjfr
force-pushed
the
dynamic_streams_fix
branch
2 times, most recently
from
d340088
to
b818607
Compare
philippjfr
force-pushed
the
dynamic_streams_fix
branch
from
b818607
to
8a4e61f
Compare
|
Looks good to me! |
|
Ready to merge. |
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Dynamicutility allows applying an operation dynamically. When applying an operation with a stream in this way currently the stream is updated with all the operations parameters. This is problematic for two reasons, it overrides defaults you've set on your stream and it currently triggers the stream to update which can cause bad loops.This PR ensures that the stream only inherits parameter values which are not already defined on the stream and ensures that simply applying the dynamic operation does not trigger stream subscribers to be notified.